Fix NEGATIVE_CODE_ERROR in libev ev.c sigfdcb#514
Open
mikhailnov wants to merge 1 commit intolinux-audit:masterfrom
Open
Fix NEGATIVE_CODE_ERROR in libev ev.c sigfdcb#514mikhailnov wants to merge 1 commit intolinux-audit:masterfrom
mikhailnov wants to merge 1 commit intolinux-audit:masterfrom
Conversation
Add check for negative return value from read() before using it in pointer arithmetic. This prevents undefined behavior when read() returns -1 on error. Similar fix was applied to infy_cb in commit 87296f7 ("Fix a libev static analysis warning"). Svace report (for audit-userspace v3.0.8): Variable 'res', which might receive a negative value at ev.c:2966 by calling function 'read', is used without checking at ev.c:2969. (CWE129, CWE394, CWE606) Co-authored-by: Z.AI GLM-5
Contributor
|
As mentioned in the other issue, I don't like changes to libev. However, in this case it is in the signalfd code which we don't use. Since we don't use signalfds, it doesn't affect audit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check for negative return value from read() before using it in pointer arithmetic. This prevents undefined behavior when read() returns -1 on error.
Similar fix was applied to infy_cb in commit 87296f7 ("Fix a libev static analysis warning").
Svace report (for audit-userspace v3.0.8):
Variable 'res', which might receive a negative value at ev.c:2966
by calling function 'read', is used without checking at ev.c:2969.
(CWE129, CWE394, CWE606)